Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors breadcrumb handling by introducing a shared BreadcrumbStore contract in @hawk.so/core and updating the JavaScript SDK to use a browser-specific implementation (BrowserBreadcrumbStore) instead of the previous BreadcrumbManager.
Changes:
- Added
BreadcrumbStore(plus related types) to@hawk.so/coreand re-exported them from the core entrypoint. - Refactored the JavaScript SDK breadcrumbs implementation to
BrowserBreadcrumbStoreand updatedCatcherto use the new store API (add/get/clear). - Updated JavaScript tests and types to align with the new names and API surface (and removed the local
breadcrumbs-api.tstype).
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/javascript/tests/catcher.user.test.ts | Updates singleton reset/import to BrowserBreadcrumbStore. |
| packages/javascript/tests/catcher.transport.test.ts | Updates singleton reset/import to BrowserBreadcrumbStore. |
| packages/javascript/tests/catcher.test.ts | Updates imports/reset and helper ordering. |
| packages/javascript/tests/catcher.global-handlers.test.ts | Updates singleton reset/import to BrowserBreadcrumbStore. |
| packages/javascript/tests/catcher.context.test.ts | Updates singleton reset/import to BrowserBreadcrumbStore. |
| packages/javascript/tests/catcher.breadcrumbs.test.ts | Updates singleton reset/import to BrowserBreadcrumbStore. |
| packages/javascript/tests/catcher.addons.test.ts | Updates singleton reset/import to BrowserBreadcrumbStore. |
| packages/javascript/tests/breadcrumbs.test.ts | Renames the suite and updates API calls to add/get/clear. |
| packages/javascript/src/types/index.ts | Re-exports breadcrumb store types from @hawk.so/core. |
| packages/javascript/src/types/breadcrumbs-api.ts | Removes the local BreadcrumbsAPI definition in favor of core types. |
| packages/javascript/src/catcher.ts | Switches from BreadcrumbManager to BrowserBreadcrumbStore and updates the public breadcrumbs getter typing. |
| packages/javascript/src/addons/breadcrumbs.ts | Introduces BrowserBreadcrumbStore implementing the core BreadcrumbStore contract and renames browser hint type. |
| packages/core/src/index.ts | Re-exports breadcrumb store types from the core package entrypoint. |
| packages/core/src/breadcrumbs/breadcrumb-store.ts | Adds the new shared breadcrumb store contract and associated types. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Dobrunia
approved these changes
Apr 1, 2026
Member
|
don't forget to bump version |
Member
Author
Thx for reminder. |
Reversean
force-pushed
the
refactor/breadcrumb-store
branch
from
9890ddb to
afc73fa
Compare
neSpecc
approved these changes
Apr 9, 2026
neSpecc
requested changes
Apr 22, 2026
Reversean
force-pushed
the
refactor/breadcrumb-store
branch
from
acafb78 to
31d54df
Compare
Reversean
force-pushed
the
refactor/breadcrumb-store
branch
2 times, most recently
from
b8c9b5c to
c049bd4
Compare
neSpecc
reviewed
May 2, 2026
Reversean
force-pushed
the
refactor/breadcrumb-store
branch
3 times, most recently
from
1bac011 to
3f7a6fc
Compare
neSpecc
approved these changes
May 6, 2026
…ted in catcher event processing pipeline - BreadcrumbStore abstraction and browser implementation added - MessageProcessor interface and MessageHint type - BrowserMessageProcessor, BreadcrumbsMessageProcessor, ConsoleCatcherMessageProcessor, DebugMessageProcessor - replaced inline addon logic with sequential MessageProcessor pipeline - rearranged core files and directories
Reversean
force-pushed
the
refactor/breadcrumb-store
branch
from
9248931 to
9e5d66a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Part of the broader effort to extract environment-agnostic logic into
@hawk.so/core(#151).BreadcrumbManagerwas a concrete, browser-coupled class living in@hawk.so/javascript—Catcherdepended directly on it, making breadcrumb support impossible to share or override in a non-browser runtime.What changed and why
BreadcrumbStoreis an interface extracted into@hawk.so/core.Catchernow depends on that interface rather than the browser implementation.BrowserBreadcrumbStore(the renamedBreadcrumbManager) is the browser-specific implementation that stays in@hawk.so/javascript.Core defines the contract, concrete catchers wire in the environment-appropriate implementation. A future
NodeCatchercan provide its ownBreadcrumbStorewithout inheriting any browser code.Changes
BreadcrumbStoreinterface added and exportedBreadcrumbManagerrenamed toBrowserBreadcrumbStore, now implementsBreadcrumbStore;Catcherupdated to depend on the interface